Repository navigation
feat: verify resource collector in source and packed smoke - #351
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed September 23, 2026, 9:08 AM ET / 13:08 UTC (Revision 12). ClawSweeper reviewWhat this changesAdds optional resource-collector checks to Plugin Inspector’s source and packed-package smoke runs, advances the source pin, and documents the measurements’ limits. Merge readiness✅ Ready for maintainer review Keep open: this adds useful coverage absent from main, and no introduced correctness or security defect was found. Historical collector proof remains relevant because all five implementation and workflow files are unchanged. Priority: P2 Review scores
Verification
How this fits togetherCrabpot checks OpenClaw plugin compatibility using Plugin Inspector. Its smoke runner exercises selected source or installed packages and saves reports that CI uses to detect broken contracts. flowchart LR
A[Source checkout] --> C[Smoke runner]
B[Packed installation] --> C
C --> D[Public collector export]
D --> E[Child snapshots and timer checks]
E --> F[Completion and cleanup checks]
F --> G[Resource report and CI result]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep collector-contract verification in the existing smoke runner, with explicit package selection and separate reporting from plugin workload measurements. Do we have a high-confidence way to reproduce the issue? Not applicable: this adds smoke coverage rather than repairing a reproduced product failure; current main demonstrably lacks the collector checks. Is this the best way to solve the issue? Yes: extending the existing runner and resolving the public package export checks the intended packaging contract without introducing another profiler. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 407299b17af5. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (11 earlier review cycles; latest 8 shown)
|
41d693f to
114169b
Compare
|
@clawsweeper re-review Please review exact head 114169b after resolving the main-branch pin conflict. The collector revision contains main's pin; all eight focused source/consumer tests passed after rebase. Fresh CI is running. |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
@clawsweeper re-review exact head |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
3c6a597 to
41707e1
Compare
|
@clawsweeper re-review exact head |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
15bf6a4 to
5c5c801
Compare
5c5c801 to
7851786
Compare
What Problem This Solves
Crabpot smoke checks did not verify Plugin Inspector's public resource collector export in both source and packed-package installations.
User Impact
CI can detect missing collector exports or broken snapshot and resource-delta behavior before consumers rely on them. This checks the collector contract only; it does not measure plugin workload cost.
Why This Change Was Made
Advance the Inspector source pin to
e2f36f1cdf943826c37303e3632866e12eaf15ce, containing the collector API, and add opt-in--resourcescoverage to the existing smoke runner. The source and packed CI lanes select their exact installation explicitly and resolve the publicresource-profileexport.A fresh child checks JSON-transported snapshots, a retained 1 MiB Buffer, and a timer added and removed. The runner requires successful command completion and cleanup before retaining the collector report. The npm package pin stays at 0.3.26; older published packages are not claimed to contain this API.
Evidence
7851786f4e5f94f462ad648d53e24ea4b9ee41b5; frozen base:407299b17af54c48ffc117c2536097f6c40bcc6e.ef3a42c85560479fc90ac6b7bf09f372d5eeeb09; full diff SHA-256:c49a860da2753ddb5a4fead6a4406dd8238dbe35fc31dd2adf5390ce4475a491.77aec050a7cd9bb1045588b6cd1cea917a596153a7a8030554234d197d8de340. Source receipt SHA-256d5c323d7052237e86db23bf07b2dc4ec5dae38bc54634b2ca9bbe8d80ca38233; packed receipt SHA-256956ef77913fe8f3e01268af90543252ee6b479bc75cb0289d9897a4fcd5bfbe1. Both record Node 24.21.0/Linux x64, stable child/thread identities, a 1 MiB ArrayBuffer increase, and timer +1/-1 with the resource map restored. Independent receipt audit verified exact-head artifact binding and every raw-to-delta value. This is collector-contract verification, not Gateway workload or performance qualification.5c5c8012a1295ec99a687932176de5e07d6730e6: Ubuntu job passed all eight focused tests and completed the source/packed smoke step in 24 seconds. CI artifact, SHA-2569ff82a670a6188603f4ccb480eaf5204109d0e6d618268d5a8ff41ae1cb205aa, was verified against that head. Both collector receipts recorded Node 24.21.0/Linux x64, stable child/thread identities, a 1 MiB ArrayBuffer increase, and timer +1/-1. Independent audit verified the archive binding, source-to-packed execution chain, and every reported snapshot delta. This is prior-head collector-contract proof, not qualification of the new head.capture-contracts.test.mjsandci-policy.test.mjs:EOWNERSTART(command supervisor startup timed out); the latter also reported that command cleanup was not confirmed. These were failed startup admissions with an unproven root cause, and the required aggregate failed. This integration does not repair or waive those failures.Fixture Impact
Fixture Verification
npm testnode scripts/sync-fixtures.mjs --checknode scripts/run-contract-smoke.mjsNotes
No Gateway workload, memory-release, peak-memory or leak claim. CPU/RSS observations belong to the child process; the other memory/resource observations belong to its main thread. An empty child environment is not a network sandbox. No release or production deployment is included.